Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add label-selector for watching namespace #715

Merged
merged 14 commits into from
Oct 28, 2021

Conversation

gxthrj
Copy link
Contributor

@gxthrj gxthrj commented Oct 18, 2021

Please answer these questions before submitting a pull request

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #715 (4808ad2) into master (a01888b) will decrease coverage by 0.66%.
The diff coverage is 4.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
- Coverage   32.36%   31.70%   -0.67%     
==========================================
  Files          65       66       +1     
  Lines        6488     6640     +152     
==========================================
+ Hits         2100     2105       +5     
- Misses       4137     4280     +143     
- Partials      251      255       +4     
Impacted Files Coverage Δ
pkg/ingress/compare.go 0.00% <0.00%> (ø)
pkg/ingress/namespace.go 0.00% <0.00%> (ø)
pkg/ingress/controller.go 1.01% <5.00%> (-0.05%) ⬇️
pkg/config/config.go 62.50% <13.79%> (-23.95%) ⬇️
cmd/ingress/ingress.go 75.82% <50.00%> (-1.45%) ⬇️
pkg/ingress/status.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a290f12...4808ad2. Read the comment docs.

cmd/ingress/ingress.go Outdated Show resolved Hide resolved
cmd/ingress/ingress.go Outdated Show resolved Hide resolved
pkg/ingress/namespace.go Outdated Show resolved Hide resolved
pkg/ingress/namespace.go Outdated Show resolved Hide resolved
pkg/ingress/namespace.go Outdated Show resolved Hide resolved
pkg/ingress/namespace.go Outdated Show resolved Hide resolved
@tao12345666333 tao12345666333 added this to In progress in v1.4 Planning via automation Oct 18, 2021
@tao12345666333 tao12345666333 added this to the 1.4.0 milestone Oct 18, 2021
docs/en/latest/practices/the-hard-way.md Show resolved Hide resolved
pkg/ingress/compare.go Outdated Show resolved Hide resolved
cmd/ingress/ingress.go Outdated Show resolved Hide resolved
pkg/ingress/controller.go Outdated Show resolved Hide resolved
pkg/ingress/namespace.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
@tao12345666333
Copy link
Member

ping @gxthrj for update and fix e2e test cases.

@gxthrj
Copy link
Contributor Author

gxthrj commented Oct 26, 2021

ping @gxthrj for update and fix e2e test cases.

Let me have a look.

pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
v1.4 Planning automation moved this from In progress to Reviewer approved Oct 28, 2021
@gxthrj gxthrj merged commit 65f7c88 into apache:master Oct 28, 2021
v1.4 Planning automation moved this from Reviewer approved to Done Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

ingress/controller.go:530 service kube-system/openebs.io-local not found
5 participants