Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: add tag omitempty for the fields in this data structure ApisixRouteHTTPMatchExpr #723

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Bugfix: add tag omitempty for the fields in this data structure ApisixRouteHTTPMatchExpr #723

merged 1 commit into from
Nov 11, 2021

Conversation

chzhuo
Copy link
Contributor

@chzhuo chzhuo commented Oct 27, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues

Bugfix

  • Description
    In the ApisixRoute CRD:
    image
    So the field value and set can't appear at the same time
    But the golang data structure will be marshal to value: null or set: null, this will cause CRD checking error

  • How to fix?
    Adding tag omitempty to this field

@tao12345666333 tao12345666333 merged commit da30386 into apache:master Nov 11, 2021
@tao12345666333
Copy link
Member

Thanks!

Sindweller pushed a commit to Sindweller/apisix-ingress-controller that referenced this pull request Nov 25, 2021
@chzhuo @Sindweller
fix field tag omitempty (apache#723)
6768f0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@tokers tokers tokers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chzhuo @tao12345666333 @tokers