Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Grafana Dashboard Configuration #731

Merged
merged 6 commits into from
Dec 31, 2021
Merged

Conversation

Sindweller
Copy link
Contributor

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues


New feature or improvement

grafana-1

grafana-2

grafana-3

@tao12345666333
Copy link
Member

ping @Sindweller any updates?

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021

Codecov Report

Merging #731 (4affd60) into master (b127ff4) will increase coverage by 0.64%.
The diff coverage is 34.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
+ Coverage   32.50%   33.14%   +0.64%     
==========================================
  Files          66       67       +1     
  Lines        6800     7142     +342     
==========================================
+ Hits         2210     2367     +157     
- Misses       4340     4505     +165     
- Partials      250      270      +20     
Impacted Files Coverage Δ
pkg/api/router/router.go 72.72% <ø> (-2.28%) ⬇️
pkg/api/validation/apisix_consumer.go 0.00% <0.00%> (ø)
pkg/api/validation/apisix_route.go 21.73% <0.00%> (+2.50%) ⬆️
pkg/api/validation/apisix_tls.go 0.00% <0.00%> (ø)
pkg/api/validation/apisix_upstream.go 0.00% <0.00%> (ø)
pkg/apisix/apisix.go 67.50% <ø> (ø)
pkg/apisix/schema.go 62.26% <0.00%> (-2.45%) ⬇️
pkg/ingress/apisix_cluster_config.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_consumer.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_route.go 0.00% <0.00%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b127ff4...4affd60. Read the comment docs.

@Sindweller Sindweller marked this pull request as ready for review November 25, 2021 03:08
@tao12345666333
Copy link
Member

Can you add a document describing how to monitor and use this dashboard? Thanks

If you need any help please feel free to ping me.

@tao12345666333 tao12345666333 added documentation Improvements or additions to documentation triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Nov 25, 2021
@tokers
Copy link
Contributor

tokers commented Nov 29, 2021

@Sindweller What does the cluster health check value mean?

@Sindweller
Copy link
Contributor Author

Can you add a document describing how to monitor and use this dashboard? Thanks

If you need any help please feel free to ping me.

working on it now.

@Sindweller
Copy link
Contributor Author

@Sindweller What does the cluster health check value mean?

It increases when checkClusterHealth is called to record a successful health check for default cluster.

@tokers
Copy link
Contributor

tokers commented Nov 30, 2021

@Sindweller What does the cluster health check value mean?

It increases when checkClusterHealth is called to record a successful health check for default cluster.

OK, so what about APISIX Health Check Calls, so that we know the usage of this metrics.

@tao12345666333
Copy link
Member

@Sindweller Thanks! It looks great to me!

Please fix the markdown lint error. Then we can merge this one.

@tao12345666333 tao12345666333 added this to In progress in v1.5 Planning via automation Dec 31, 2021
@tao12345666333 tao12345666333 added this to the 1.5.0 milestone Dec 31, 2021
@tao12345666333
Copy link
Member

@Sindweller LGTM. Thanks!

@gxthrj gxthrj changed the title feat: Grafana Dashboard Configuration docs: Grafana Dashboard Configuration Dec 31, 2021
v1.5 Planning automation moved this from In progress to Reviewer approved Dec 31, 2021
@gxthrj gxthrj merged commit ae69cd3 into apache:master Dec 31, 2021
v1.5 Planning automation moved this from Reviewer approved to Done Dec 31, 2021
@Sindweller Sindweller deleted the grafana-json branch December 31, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants