Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Remove route timeout default value #733

Merged

Conversation

chzhuo
Copy link
Contributor

@chzhuo chzhuo commented Nov 2, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bugfix

  • New feature provided

  • Improve performance

  • Backport patches

  • Related issues


Bugfix

  • Description
    The controller will set default timeout 60s to the Apisix Route if not assigned timeout in the ApisixRoute CRD
    And The Apisix Route timeout will overwrite the timeout option which set in Upstream configuration.
    image

  • How to fix?
    Keeping the original logic, not assign default timeout to the Apisix Route

@chzhuo chzhuo changed the title remove route timeout default value bug: Remove route timeout default value Nov 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #733 (006e956) into master (4a862e2) will increase coverage by 0.25%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
+ Coverage   31.70%   31.95%   +0.25%     
==========================================
  Files          66       66              
  Lines        6640     6641       +1     
==========================================
+ Hits         2105     2122      +17     
+ Misses       4280     4271       -9     
+ Partials      255      248       -7     
Impacted Files Coverage Δ
pkg/kube/translation/apisix_route.go 19.10% <20.00%> (-0.54%) ⬇️
pkg/apisix/route.go 37.76% <0.00%> (+2.09%) ⬆️
pkg/apisix/cluster.go 30.75% <0.00%> (+3.50%) ⬆️
pkg/apisix/plugin.go 100.00% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 774077a...006e956. Read the comment docs.

@tao12345666333
Copy link
Member

hi #754 has been merged to fix e2e CI. Could you please merge from master?

@chzhuo chzhuo force-pushed the fix_route_timeout_default_value branch from 6d2f08a to 006e956 Compare November 15, 2021 08:44
@tao12345666333 tao12345666333 merged commit 9fe7298 into apache:master Nov 24, 2021
@tao12345666333
Copy link
Member

Thanks!

Sindweller pushed a commit to Sindweller/apisix-ingress-controller that referenced this pull request Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants