Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ingress do not watching any namespace when namespaceSelector is empty #742

Merged
merged 5 commits into from
Nov 26, 2021

Conversation

gxthrj
Copy link
Contributor

@gxthrj gxthrj commented Nov 8, 2021

…empty

Please answer these questions before submitting a pull request


@chzhuo
Copy link
Contributor

chzhuo commented Nov 8, 2021

In the method initWatchingNamespaceByLabels, The watchingNamespace will be filled .
image

@gxthrj
Copy link
Contributor Author

gxthrj commented Nov 8, 2021

In the method initWatchingNamespaceByLabels, The watchingNamespace will be filled . image

Yes, I just get your point, the newly created namespace will fail to watch.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021

Codecov Report

Merging #742 (29fb2f6) into master (4a862e2) will increase coverage by 0.08%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   31.70%   31.78%   +0.08%     
==========================================
  Files          66       66              
  Lines        6640     6648       +8     
==========================================
+ Hits         2105     2113       +8     
  Misses       4280     4280              
  Partials      255      255              
Impacted Files Coverage Δ
pkg/ingress/compare.go 0.00% <0.00%> (ø)
pkg/ingress/controller.go 1.01% <0.00%> (ø)
pkg/api/validation/utils.go 44.44% <100.00%> (+12.01%) ⬆️
pkg/types/labels.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 774077a...29fb2f6. Read the comment docs.

@tao12345666333 tao12345666333 added this to In progress in v1.4 Planning via automation Nov 10, 2021
@tao12345666333 tao12345666333 added this to the 1.4.0 milestone Nov 10, 2021
@tao12345666333 tao12345666333 self-assigned this Nov 10, 2021
v1.4 Planning automation moved this from In progress to Reviewer approved Nov 24, 2021
@tao12345666333
Copy link
Member

ping @gxthrj any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants