-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ingress do not watching any namespace when namespaceSelector is empty #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #742 +/- ##
==========================================
+ Coverage 31.70% 31.78% +0.08%
==========================================
Files 66 66
Lines 6640 6648 +8
==========================================
+ Hits 2105 2113 +8
Misses 4280 4280
Partials 255 255
Continue to review full report at Codecov.
|
lingsamuel
approved these changes
Nov 15, 2021
tokers
reviewed
Nov 15, 2021
tao12345666333
approved these changes
Nov 24, 2021
ping @gxthrj any update? |
tokers
approved these changes
Nov 26, 2021
Sindweller
pushed a commit
to Sindweller/apisix-ingress-controller
that referenced
this pull request
Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…empty
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
bug: The newly created namespace will not be watched #741