Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add Apache License header in each go source file. #75

Merged
merged 1 commit into from
Dec 10, 2020
Merged

chore: add Apache License header in each go source file. #75

merged 1 commit into from
Dec 10, 2020

Conversation

tokers
Copy link
Contributor

@tokers tokers commented Dec 10, 2020 •
edited
Loading

Files are filtered by:

find . -name "*.go"

@tokers
Copy link
Contributor Author

tokers commented Dec 10, 2020

@membphis @moonming @gxthrj Please take a look.

moonming
moonming reviewed Dec 10, 2020
View reviewed changes
Copy link
Member

@moonming moonming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
and we need add CI to check ASF header later.

@moonming
Copy link
Member

@Firstsawyou please add CI check for ASF header.

@gxthrj
Copy link
Contributor

gxthrj commented Dec 10, 2020

Related to #38 , only golang files in this PR

@gxthrj gxthrj merged commit d7d8bdb into apache:master Dec 10, 2020
@tokers tokers deleted the chore/asf-license branch December 10, 2020 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonming moonming moonming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tokers @moonming @gxthrj