fix: use independent dns service for UDP e2e test #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce in kube-system namespace
|
@gxthrj ping |
tokers
reviewed
Nov 11, 2021
test/e2e/scaffold/k8s.go
Outdated
| if readyNum == desired { | ||
| return "Service is now available", nil | ||
| } | ||
| return "Endpoints not ready yet", nil |
There was a problem hiding this comment.
Add the expected number and the actual number to the message, it's useful to troubleshoot issues.
Codecov Report
@@ Coverage Diff @@
## master #753 +/- ##
==========================================
+ Coverage 31.69% 31.70% +0.01%
==========================================
Files 65 66 +1
Lines 6639 6640 +1
==========================================
+ Hits 2104 2105 +1
Misses 4280 4280
Partials 255 255
Continue to review full report at Codecov.
|
|
CI 🟢 |
Sindweller
pushed a commit
to Sindweller/apisix-ingress-controller
that referenced
this pull request
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use independent dns service for UDP e2e test, avoid create resource in kube-system namespace
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
bug: e2e test will fail randomly #751