Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Issue & PR template #771

Merged
merged 3 commits into from
Dec 14, 2021
Merged

chore: Issue & PR template #771

merged 3 commits into from
Dec 14, 2021

Conversation

mayocream
Copy link
Contributor

@mayocream mayocream commented Nov 25, 2021

Please answer these questions before submitting a pull request

The original PR template is really hard to use.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to keep the choice of PR type in order to distinguish whether it is a feature or a bugfix, etc.

@mayocream mayocream marked this pull request as ready for review December 10, 2021 23:22
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gxthrj gxthrj merged commit 4a6509c into apache:master Dec 14, 2021
Sindweller pushed a commit to Sindweller/apisix-ingress-controller that referenced this pull request Dec 18, 2021
tao12345666333 pushed a commit to tao12345666333/ingress-controller that referenced this pull request Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could we use a better description Issue/PR template? Pull Request template doesn't conform our demand
3 participants