feat: Initial support for Gateway API #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
…troller into feat-gateway-api
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
tao12345666333
added
changelog
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #789 +/- ##
==========================================
- Coverage 33.14% 32.58% -0.57%
==========================================
Files 67 69 +2
Lines 7142 7274 +132
==========================================
+ Hits 2367 2370 +3
- Misses 4505 4634 +129
Partials 270 270
Continue to review full report at Codecov.
|
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
tokers
reviewed
Dec 9, 2021
gxthrj
reviewed
Dec 9, 2021
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
gxthrj
reviewed
Dec 23, 2021
| } | ||
| } | ||
|
|
||
| func (c *gatewayController) sync(ctx context.Context, ev *types.Event) error { |
There was a problem hiding this comment.
I can not see the logic for syncing to APISIX in sync method.
There was a problem hiding this comment.
As I wrote in the description of the PR.
Note: This feature is still under development, and the route has not yet been published to the Apache APISIX Gateway
Only initial support in this PR. Mainly to implement the synchronization of the Gateway resource status.
Once all features are submitted through a PR, then this PR will be huge. @gxthrj
tokers
reviewed
Dec 24, 2021
tao12345666333
force-pushed
the
feat-gateway-api
branch
from
93b28b4
to
b6b6e2c
Compare
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
tao12345666333
force-pushed
the
feat-gateway-api
branch
from
b6b6e2c
to
e647ee2
Compare
tokers
approved these changes
Dec 24, 2021
gxthrj
approved these changes
Dec 24, 2021
Sindweller
pushed a commit
to Sindweller/apisix-ingress-controller
that referenced
this pull request
Dec 31, 2021
This was referenced May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Related issues
feat: GatewayAPI Support #644
New feature or improvement
Describe the details and related test reports.
In this version, the initial Gateway API support has been added, and a switch has been added to control whether to enable this feature. So it can be safely merged.
Changes in this PR:
Note: This feature is still under development, and the route has not yet been published to the Apache APISIX Gateway