Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When the spec field of the ApisixUpstream resource is empty, it … #794

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

Brhetty
Copy link
Contributor

@Brhetty Brhetty commented Dec 13, 2021

…will panic

Please answer these questions before submitting a pull request

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #794 (7711f65) into master (413e7ca) will not change coverage.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #794   +/-   ##
=======================================
  Coverage   33.09%   33.09%           
=======================================
  Files          67       67           
  Lines        7127     7127           
=======================================
  Hits         2359     2359           
  Misses       4499     4499           
  Partials      269      269           
Impacted Files Coverage Δ
pkg/ingress/apisix_upstream.go 0.00% <0.00%> (ø)
pkg/ingress/controller.go 1.01% <0.00%> (ø)
pkg/kube/translation/translator.go 46.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413e7ca...7711f65. Read the comment docs.

@tao12345666333 tao12345666333 added the bug Something isn't working label Dec 13, 2021
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

And we can update the CRD make spec is required.

@tokers tokers merged commit d4c5b09 into apache:master Dec 14, 2021
Sindweller pushed a commit to Sindweller/apisix-ingress-controller that referenced this pull request Dec 18, 2021
…will panic (apache#794)

Co-authored-by: byy <byy@localhost.localdomain>
tao12345666333 pushed a commit to tao12345666333/ingress-controller that referenced this pull request Dec 23, 2021
…will panic (apache#794)

Co-authored-by: byy <byy@localhost.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants