Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: specify the K8S cluster version used for the test #797

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

tao12345666333
Copy link
Member

Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com

Type of change:

  • CI

What this PR does / why we need it:

Specify the K8S cluster version used for the test. To avoid CI failure due to inconsistent local environment version.

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2021

Codecov Report

Merging #797 (c1fbfbd) into master (d4c5b09) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
+ Coverage   33.09%   33.15%   +0.05%     
==========================================
  Files          67       68       +1     
  Lines        7127     7143      +16     
==========================================
+ Hits         2359     2368       +9     
- Misses       4499     4505       +6     
- Partials      269      270       +1     
Impacted Files Coverage Δ
pkg/api/router/router.go 72.72% <0.00%> (-2.28%) ⬇️
pkg/ingress/controller.go 1.00% <0.00%> (-0.01%) ⬇️
pkg/api/router/apisix_healthz.go 66.66% <0.00%> (ø)
pkg/api/server.go 82.27% <0.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c5b09...c1fbfbd. Read the comment docs.

@gxthrj
Copy link
Contributor

gxthrj commented Dec 15, 2021

e2e failed. Re-runed.

@tao12345666333 tao12345666333 merged commit eeb7a49 into apache:master Dec 15, 2021
@tao12345666333
Copy link
Member Author

It's green! Merged.

@tao12345666333 tao12345666333 deleted the improve-ci branch December 15, 2021 16:58
Sindweller pushed a commit to Sindweller/apisix-ingress-controller that referenced this pull request Dec 18, 2021
tao12345666333 added a commit to tao12345666333/ingress-controller that referenced this pull request Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants