Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some wrong or invalid logs #804

Merged
merged 2 commits into from
Dec 20, 2021
Merged

fix: some wrong or invalid logs #804

merged 2 commits into from
Dec 20, 2021

Conversation

nic-6443
Copy link
Member

@nic-6443 nic-6443 commented Dec 19, 2021

Type of change:

  • Bugfix

empty log object:
image

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2021

Codecov Report

Merging #804 (4160007) into master (eeb7a49) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #804   +/-   ##
=======================================
  Coverage   33.14%   33.15%           
=======================================
  Files          67       68    +1     
  Lines        7142     7143    +1     
=======================================
+ Hits         2367     2368    +1     
  Misses       4505     4505           
  Partials      270      270           
Impacted Files Coverage Δ
pkg/ingress/ingress.go 6.89% <0.00%> (ø)
test/e2e/e2e.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb7a49...4160007. Read the comment docs.

@nic-6443 nic-6443 changed the title fix: fields in logs do not match variables fix: some wrong or invalid logs Dec 19, 2021
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Dec 19, 2021
@tokers tokers merged commit 7b62375 into apache:master Dec 20, 2021
tao12345666333 pushed a commit to tao12345666333/ingress-controller that referenced this pull request Dec 23, 2021
Sindweller pushed a commit to Sindweller/apisix-ingress-controller that referenced this pull request Dec 31, 2021
@nic-6443 nic-6443 deleted the nic/fix-log branch April 3, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants