feat: refactor ApisixPluginConfig and add e2e cases #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ller into feat-638
Codecov Report
@@ Coverage Diff @@
## master #815 +/- ##
==========================================
- Coverage 32.55% 32.14% -0.41%
==========================================
Files 68 71 +3
Lines 7284 7727 +443
==========================================
+ Hits 2371 2484 +113
- Misses 4643 4968 +325
- Partials 270 275 +5
Continue to review full report at Codecov.
|
…dify crd yaml (apache#791)" This reverts commit 03e93bf. # Conflicts: # pkg/kube/translation/apisix_pluginconfig.go # samples/deploy/crd/v1/ApisixPluginConfig.yaml # test/e2e/plugins/plugin_config.go
tao12345666333
requested review from
gxthrj,
tokers,
tao12345666333 and
lingsamuel
4 tasks
tao12345666333
approved these changes
Dec 29, 2021
pkg/ingress/apisix_pluginconfig.go
Outdated
| return err | ||
| } | ||
| var ( | ||
| ar kube.ApisixPluginConfig |
There was a problem hiding this comment.
I tend to name it ap or apc
pkg/ingress/manifest.go
Outdated
| @@ -248,6 +296,11 @@ func (c *Controller) syncManifests(ctx context.Context, added, updated, deleted | |||
| merr = multierror.Append(merr, err) | |||
| } | |||
| } | |||
| for _, sr := range updated.pluginConfigs { | |||
| if _, err := c.apisix.Cluster(clusterName).PluginConfig().Create(ctx, sr); err != nil { | |||
| pluginMap := make(apisixv1.Plugins) | ||
| if len(config.Spec.Plugins) > 0 { | ||
| for _, plugin := range config.Spec.Plugins { | ||
| if !plugin.Enable { |
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
6 tasks
6 tasks
Sindweller
pushed a commit
to Sindweller/apisix-ingress-controller
that referenced
this pull request
Dec 31, 2021
…e#815) Co-authored-by: Jintao Zhang <zhangjintao9020@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Pre-submission checklist: