Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: fetching newest Endpoint before sync #821

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

chzhuo
Copy link
Contributor

@chzhuo chzhuo commented Dec 31, 2021

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Related issue: #806

@tao12345666333 tao12345666333 added the bug Something isn't working label Dec 31, 2021
@tao12345666333 tao12345666333 added this to In progress in v1.5 Planning via automation Dec 31, 2021
@tao12345666333 tao12345666333 added this to the 1.5.0 milestone Dec 31, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 31, 2021

Codecov Report

Merging #821 (a94778d) into master (990971d) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #821      +/-   ##
==========================================
- Coverage   32.14%   32.03%   -0.12%     
==========================================
  Files          71       72       +1     
  Lines        7727     7773      +46     
==========================================
+ Hits         2484     2490       +6     
- Misses       4968     5009      +41     
+ Partials      275      274       -1     
Impacted Files Coverage Δ
pkg/ingress/endpoint.go 0.00% <0.00%> (ø)
pkg/config/config.go 64.64% <0.00%> (-1.38%) ⬇️
pkg/apisix/cluster.go 31.88% <0.00%> (-0.70%) ⬇️
pkg/ingress/ingress.go 6.76% <0.00%> (-0.06%) ⬇️
pkg/ingress/status.go 0.00% <0.00%> (ø)
pkg/ingress/namespace.go 0.00% <0.00%> (ø)
pkg/ingress/controller.go 0.94% <0.00%> (ø)
pkg/ingress/apisix_route.go 0.00% <0.00%> (ø)
pkg/apisix/noop.go 0.00% <0.00%> (ø)
pkg/apisix/stream_route.go 36.42% <0.00%> (+0.12%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae69cd3...a94778d. Read the comment docs.

v1.5 Planning automation moved this from In progress to Reviewer approved Dec 31, 2021
@chzhuo
Copy link
Contributor Author

chzhuo commented Jan 5, 2022

I want to fix the failed e2e-test, but all e2e tests are successful in my local development environment

image
The Event "ingress updated" would trigger only once in the above test case, but this log collected from apisix-ingress-controller shows the Event "ingress updated" Constantly trigger. Do you know why ?
image

@tao12345666333
Copy link
Member

Can you try to merge master branch?

@tao12345666333 tao12345666333 self-assigned this Feb 24, 2022
@tao12345666333 tao12345666333 merged commit b5448c3 into apache:master Mar 4, 2022
v1.5 Planning automation moved this from Reviewer approved to Done Mar 4, 2022
@tao12345666333
Copy link
Member

Thanks! Merged

tao12345666333 pushed a commit to tao12345666333/ingress-controller that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

bug: Special circumstance may cause expired configuration be PUT to APISIX
4 participants