Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ensure that the lease can be actively released before program shutdown to reduce the time required for failover #827

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

nic-6443
Copy link
Member

@nic-6443 nic-6443 commented Jan 3, 2022

Ensure that the lease can be actively released before program shutdown to reduce the time required for failover

Type of change:

  • Improve performance

…hutdown to reduce the time required for failover
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2022

Codecov Report

Merging #827 (116136c) into master (990971d) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
- Coverage   32.14%   31.88%   -0.27%     
==========================================
  Files          71       71              
  Lines        7727     7731       +4     
==========================================
- Hits         2484     2465      -19     
- Misses       4968     4984      +16     
- Partials      275      282       +7     
Impacted Files Coverage Δ
pkg/ingress/controller.go 0.94% <ø> (ø)
cmd/ingress/ingress.go 78.84% <100.00%> (+0.84%) ⬆️
pkg/apisix/plugin.go 80.00% <0.00%> (-20.00%) ⬇️
pkg/apisix/cluster.go 28.73% <0.00%> (-3.85%) ⬇️
pkg/apisix/route.go 36.91% <0.00%> (-2.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae69cd3...116136c. Read the comment docs.

@nic-6443 nic-6443 marked this pull request as ready for review January 4, 2022 00:11
@tao12345666333 tao12345666333 added this to In progress in v1.5 Planning via automation Jan 11, 2022
@tao12345666333 tao12345666333 added this to the 1.5.0 milestone Jan 11, 2022
@tao12345666333 tao12345666333 merged commit de52243 into apache:master Jan 11, 2022
v1.5 Planning automation moved this from In progress to Done Jan 11, 2022
@nic-6443 nic-6443 deleted the give-up-lease-while-shutdown branch April 3, 2022 14:25
tao12345666333 pushed a commit to tao12345666333/ingress-controller that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants