Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ingress/comapre.go watchingNamespac v2beta1 to v2beta3 #832

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

neverCase
Copy link
Contributor

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #832 (91c9a74) into master (e40cc31) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #832   +/-   ##
=======================================
  Coverage   32.08%   32.09%           
=======================================
  Files          70       71    +1     
  Lines        7720     7721    +1     
=======================================
+ Hits         2477     2478    +1     
  Misses       4968     4968           
  Partials      275      275           
Impacted Files Coverage Δ
pkg/ingress/compare.go 0.00% <0.00%> (ø)
test/e2e/e2e.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e40cc31...91c9a74. Read the comment docs.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@tao12345666333 tao12345666333 added this to In progress in v1.5 Planning via automation Jan 5, 2022
@tao12345666333 tao12345666333 added this to the 1.5.0 milestone Jan 5, 2022
@tao12345666333 tao12345666333 changed the title feat: update ingress/comapre.go watchingNamespac v2beta1 to v2beta3 chore: update ingress/comapre.go watchingNamespac v2beta1 to v2beta3 Jan 5, 2022
v1.5 Planning automation moved this from In progress to Reviewer approved Jan 6, 2022
@tao12345666333 tao12345666333 merged commit 81d59b5 into apache:master Jan 11, 2022
v1.5 Planning automation moved this from Reviewer approved to Done Jan 11, 2022
@neverCase neverCase deleted the update-campare branch January 17, 2022 06:14
tao12345666333 pushed a commit to tao12345666333/ingress-controller that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants