Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ApisixClusterConfig e2e test case #859

Merged
merged 1 commit into from Feb 14, 2022

Conversation

tao12345666333
Copy link
Member

  • pin the image of APISIX to stable version
  • using the new plugin list API
  • fix ApisixClusterConfig status logic

Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

fix: #857

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

* pin the image of APISIX to stable version
* using the new plugin list API
* fix ApisixClusterConfig status logic

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Comment on lines +90 to +91
docker pull apache/apisix:2.12.0-alpine
docker tag apache/apisix:2.12.0-alpine $(LOCAL_REGISTRY)/apache/apisix:dev
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will rollback to stable version before confirming that dev is available.

@tao12345666333
Copy link
Member Author

ping @tokers @gxthrj PTAL, thanks!

@tokers
Copy link
Contributor

tokers commented Feb 14, 2022

ping @tokers @gxthrj PTAL, thanks!

Approved.

@tokers tokers merged commit 6b0c139 into apache:master Feb 14, 2022
@tao12345666333 tao12345666333 deleted the fix-cluster-config branch February 14, 2022 01:58
tao12345666333 added a commit to tao12345666333/ingress-controller that referenced this pull request Apr 22, 2022
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e test: ApisixClusterConfig enable prometheus failed
3 participants