Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the-hard-way.md #875

Merged
merged 1 commit into from Feb 23, 2022
Merged

update the-hard-way.md #875

merged 1 commit into from Feb 23, 2022

Conversation

nayihz
Copy link
Contributor

@nayihz nayihz commented Feb 17, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

some infomation is outdated in the-hard-way.md

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

tao12345666333
tao12345666333 reviewed Feb 17, 2022
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks！

docs/en/latest/practices/the-hard-way.md Outdated Show resolved Hide resolved
tao12345666333
tao12345666333 approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@tao12345666333
Copy link
Member

ping @lingsamuel @tokers @gxthrj for review. Thanks!

@gxthrj gxthrj merged commit 27f0cfa into apache:master Feb 23, 2022
@nayihz nayihz deleted the update-hard-way-doc branch February 26, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@gxthrj gxthrj gxthrj approved these changes

@lingsamuel lingsamuel lingsamuel approved these changes

@tokers tokers Awaiting requested review from tokers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nayihz @tao12345666333 @gxthrj @lingsamuel