Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add update command to Makefile #881

Merged
merged 3 commits into from Feb 23, 2022
Merged

feat: add update command to Makefile #881

merged 3 commits into from Feb 23, 2022

Conversation

mangoGoForward
Copy link
Contributor

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Resolved #879

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@mangoGoForward
Copy link
Contributor Author

mangoGoForward commented Feb 22, 2022 •
edited

cc @tao12345666333 @lingsamuel

@tao12345666333 tao12345666333 mentioned this pull request Feb 22, 2022
Closed
lingsamuel
lingsamuel requested changes Feb 22, 2022
View reviewed changes
Makefile Show resolved Hide resolved
mangoGoForward and others added 2 commits February 22, 2022 17:34
@mangoGoForward
remove codegen.
324390f 
Signed-off-by: mango <xu.weiKyrie@foxmail.com>
@mangoGoForward
change make codegen to make update-codegen when codes is out of date
3f28f59 
Signed-off-by: mango <xu.weiKyrie@foxmail.com>
@lingsamuel
Copy link
Member

Thanks!

@tao12345666333
Copy link
Member

Thanks!

@tao12345666333 tao12345666333 merged commit 26a1f43 into apache:master Feb 23, 2022
@mangoGoForward mangoGoForward deleted the feat/add-update-command branch February 23, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@lingsamuel lingsamuel lingsamuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Makefile: add update- for verify-
3 participants
@mangoGoForward @lingsamuel @tao12345666333