fix: endless retry if namespace doesn't exist #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
==========================================
- Coverage 32.07% 32.03% -0.04%
==========================================
Files 71 71
Lines 7739 7748 +9
==========================================
Hits 2482 2482
- Misses 4982 4991 +9
Partials 275 275
Continue to review full report at Codecov.
|
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
gxthrj
approved these changes
Feb 23, 2022
| zap.String("event_type", event.Type.String()), | ||
| zap.String("namespace", event.Object.(string)), | ||
| ) | ||
| c.workqueue.Forget(event) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com
Type of change:
Fixes #816
What this PR does / why we need it:
I couldn't find a stable way to reproduce this issue without changing the code, so there is no e2e test.
The only case this PR addresses is the error not found. Please add other cases if necessary.
If anyone else wants to reproduce this issue, please postpone the Create/Update events (example: wrap the function in a goroutine and add a time.Sleep at the beginning).