Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add format tool #885

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Conversation

mangoGoForward
Copy link
Contributor

Signed-off-by: mango xu.weiKyrie@foxmail.com

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Add a formatting tool and format project files. Resolved #884

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: mango <xu.weiKyrie@foxmail.com>
Signed-off-by: mango <xu.weiKyrie@foxmail.com>
@lingsamuel lingsamuel changed the title Feat/add format tool feat: add format tool Feb 23, 2022
Makefile Outdated Show resolved Hide resolved
Signed-off-by: mango <xu.weiKyrie@foxmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #885 (aac3c65) into master (77383b8) will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
- Coverage   32.05%   31.76%   -0.29%     
==========================================
  Files          70       71       +1     
  Lines        7740     7741       +1     
==========================================
- Hits         2481     2459      -22     
- Misses       4984     5000      +16     
- Partials      275      282       +7     
Impacted Files Coverage Δ
pkg/apisix/plugin.go 80.00% <0.00%> (-20.00%) ⬇️
pkg/apisix/cluster.go 28.73% <0.00%> (-3.85%) ⬇️
pkg/apisix/route.go 36.91% <0.00%> (-2.02%) ⬇️
test/e2e/e2e.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77383b8...aac3c65. Read the comment docs.

@mangoGoForward
Copy link
Contributor Author

Hi @lingsamuel ,lint-checker-ci failed, and some hyperlink got status 500, maybe we should fix first.

@mangoGoForward
Copy link
Contributor Author

Hi @lingsamuel ,lint-checker-ci failed, and some hyperlink got status 500, maybe we should fix first.

But I can link to those websites.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks

@lingsamuel
Copy link
Member

Hi @lingsamuel ,lint-checker-ci failed, and some hyperlink got status 500, maybe we should fix first.

This could just be a coincidental failure. Just ignore it.

@lingsamuel lingsamuel merged commit e2475cf into apache:master Feb 24, 2022
@mangoGoForward mangoGoForward deleted the feat/add-format-tool branch February 25, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile: add a formatting tool
4 participants