Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix #887 #890

Merged
merged 2 commits into from
Mar 2, 2022
Merged

docs: fix #887 #890

merged 2 commits into from
Mar 2, 2022

Conversation

FesonX
Copy link
Contributor

@FesonX FesonX commented Feb 26, 2022

Type of change:

  • Bugfix

What this PR does / why we need it:

Fix #887

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

tao12345666333
tao12345666333 reviewed Feb 26, 2022
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

tao12345666333
tao12345666333 approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 merged commit 8d25525 into apache:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@lingsamuel lingsamuel lingsamuel approved these changes

@gxthrj gxthrj Awaiting requested review from gxthrj

@tokers tokers Awaiting requested review from tokers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request help: "error retrieving resource lock" on APISIX Ingress Controller the Hard Way
3 participants
@FesonX @tao12345666333 @lingsamuel