Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: controller err handler should ignore not found error #893

Merged

Conversation

lingsamuel
Copy link
Member

Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com

Type of change:

  • Bugfix

What this PR does / why we need it:

Fixes: #810

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #893 (c41dad4) into master (f84a083) will decrease coverage by 0.33%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
- Coverage   32.05%   31.71%   -0.34%     
==========================================
  Files          71       72       +1     
  Lines        7775     7861      +86     
==========================================
+ Hits         2492     2493       +1     
- Misses       5009     5094      +85     
  Partials      274      274              
Impacted Files Coverage Δ
pkg/ingress/apisix_cluster_config.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_consumer.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_pluginconfig.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_route.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_tls.go 0.00% <0.00%> (ø)
pkg/ingress/apisix_upstream.go 0.00% <0.00%> (ø)
pkg/ingress/endpoint.go 0.00% <0.00%> (ø)
pkg/ingress/endpointslice.go 0.00% <0.00%> (ø)
pkg/ingress/gateway.go 0.00% <0.00%> (ø)
pkg/ingress/ingress.go 6.59% <0.00%> (-0.18%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f84a083...c41dad4. Read the comment docs.

@tao12345666333 tao12345666333 added bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Mar 2, 2022
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gxthrj gxthrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should ignore the NOT FOUND error.

v1.5 Planning automation moved this from In progress to Reviewer approved Mar 5, 2022
@tao12345666333
Copy link
Member

Please resolve conflicts. Thanks! @lingsamuel

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@lingsamuel
Copy link
Member Author

@tao12345666333 done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

bug: service not found,and then I edited it and it still kept reporting errors.
4 participants