Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up useless code #902

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

tao12345666333
Copy link
Member

Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com

Type of change:

  • Clean up

What this PR does / why we need it:

These codes were introduced in #746.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #902 (0a297f3) into master (8348d01) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #902   +/-   ##
=======================================
  Coverage   32.05%   32.06%           
=======================================
  Files          71       72    +1     
  Lines        7775     7776    +1     
=======================================
+ Hits         2492     2493    +1     
  Misses       5009     5009           
  Partials      274      274           
Impacted Files Coverage Δ
pkg/kube/translation/apisix_route.go 22.43% <ø> (ø)
pkg/kube/translation/util.go 32.71% <ø> (ø)
test/e2e/e2e.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8348d01...0a297f3. Read the comment docs.

@gxthrj gxthrj merged commit 75098d1 into apache:master Mar 9, 2022
@tao12345666333 tao12345666333 deleted the clean-up-useless-code branch March 9, 2022 07:20
tao12345666333 added a commit to tao12345666333/ingress-controller that referenced this pull request Apr 22, 2022
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants