Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add doc about installing apisix ingress with kind #933

Merged
merged 9 commits into from
Mar 27, 2022
Merged

doc: add doc about installing apisix ingress with kind #933

merged 9 commits into from
Mar 27, 2022

Conversation

Chever-John
Copy link
Contributor

@Chever-John Chever-John commented Mar 24, 2022

As title says.

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@@ -0,0 +1,83 @@
---
title: Install Ingress APISIX on Kind
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

Suggested change
title: Install Ingress APISIX on Kind
title: Install Ingress Controller by Kind

by or on?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on

@tao12345666333
Copy link
Member

Please fix the lint error.

@tao12345666333 tao12345666333 merged commit cb45119 into apache:master Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants