-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support forward-auth plugin #937
Conversation
Codecov Report
@@ Coverage Diff @@
## master #937 +/- ##
==========================================
+ Coverage 32.89% 33.05% +0.16%
==========================================
Files 72 74 +2
Lines 7661 7680 +19
==========================================
+ Hits 2520 2539 +19
Misses 4865 4865
Partials 276 276
Continue to review full report at Codecov.
|
How do I test |
You can use kind with v1.21 kubernetes |
re-run CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But due to the recent merge of #949, I think in e2e we need to tweak a little bit
@cmssczy Can you pull the latest code and make some adjustments to the test case names in e2e? so that they can be more uniform |
return s.ensureHTTPDeleteSuccess(u.String()) | ||
} | ||
|
||
func (s *Scaffold) ensureHTTPDeleteSuccess(url string) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can encapsulate a method ensureAdminOperationIsSuccessful
, and pass the request, so that we can reuse the code base of ensureHTTPPutSuccess
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. We can optimize in subsequent PRs. @cmssczy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. We can optimize in subsequent PRs. @cmssczy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move forward.
Type of change:
What this PR does / why we need it:
Pre-submission checklist: