fix: ingress update event handler not filter by watching namespaces #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
It's true that I can't reproduce it in my local environment, I didn't consider this reason before. Let me think of a way to reproduce it |
gxthrj
approved these changes
Apr 6, 2022
tao12345666333
approved these changes
Apr 6, 2022
fgksgf
pushed a commit
to fgksgf/apisix-ingress-controller
that referenced
this pull request
Apr 7, 2022
tao12345666333
pushed a commit
to tao12345666333/ingress-controller
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Fix #869
Since the ingress update event handler is not filtered according to the watching namespaces, and our e2e uses two ginkgo nodes, it will cause the lb status test case to be interfered with the ingress controller in other test cases. This is why e2e is unstable as described in #869.
Pre-submission checklist: