-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a pre-check for E2E tests #957
Conversation
The script can find we missed the prefix in some files: https://github.com/apache/apisix-ingress-controller/runs/5881903560?check_suite_focus=true |
Codecov Report
@@ Coverage Diff @@
## master #957 +/- ##
=======================================
Coverage 31.75% 31.75%
=======================================
Files 72 72
Lines 7935 7935
=======================================
Hits 2520 2520
Misses 5139 5139
Partials 276 276 Continue to review full report at Codecov.
|
Great!! |
re-run CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a check-e2e-name
rule to the Makefile? It might be more convenient
Good idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change:
What this PR does / why we need it:
In #949 we use
ginkgo --focus
to run test cases in parallel, but some newly added cases may not follow the naming convention. So we need to add a pre-check to avoid some E2E cases not running.Pre-submission checklist:
Test
Tested on Linux: