Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pre-check for E2E tests #957

Merged
merged 7 commits into from
Apr 11, 2022
Merged

Conversation

fgksgf
Copy link
Member

@fgksgf fgksgf commented Apr 8, 2022

Type of change:

  • CI

What this PR does / why we need it:

In #949 we use ginkgo --focus to run test cases in parallel, but some newly added cases may not follow the naming convention. So we need to add a pre-check to avoid some E2E cases not running.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Test

Tested on Linux:
image

@fgksgf
Copy link
Member Author

fgksgf commented Apr 8, 2022

The script can find we missed the prefix in some files:
image

https://github.com/apache/apisix-ingress-controller/runs/5881903560?check_suite_focus=true

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2022

Codecov Report

Merging #957 (f4a1078) into master (4bdc947) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #957   +/-   ##
=======================================
  Coverage   31.75%   31.75%           
=======================================
  Files          72       72           
  Lines        7935     7935           
=======================================
  Hits         2520     2520           
  Misses       5139     5139           
  Partials      276      276           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bdc947...f4a1078. Read the comment docs.

@tao12345666333
Copy link
Member

The script can find we missed the prefix in some files

Great!!

@tao12345666333
Copy link
Member

re-run CI.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a check-e2e-name rule to the Makefile? It might be more convenient

@fgksgf
Copy link
Member Author

fgksgf commented Apr 10, 2022

Should we add a check-e2e-name rule to the Makefile? It might be more convenient

Good idea

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makefile Outdated Show resolved Hide resolved
@tao12345666333 tao12345666333 merged commit 22cfb5e into apache:master Apr 11, 2022
@fgksgf fgksgf deleted the add-e2e-check branch April 11, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants