Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add e2e test for serverless plugin #964

Merged
merged 11 commits into from
Apr 15, 2022
Merged

feat: add e2e test for serverless plugin #964

merged 11 commits into from
Apr 15, 2022

Conversation

Chever-John
Copy link
Contributor

@Chever-John Chever-John commented Apr 13, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Add e2e test for serverless plugin!

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #964 (34838c3) into master (22cfb5e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #964   +/-   ##
=======================================
  Coverage   31.75%   31.75%           
=======================================
  Files          72       72           
  Lines        7935     7935           
=======================================
  Hits         2520     2520           
  Misses       5139     5139           
  Partials      276      276           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22cfb5e...34838c3. Read the comment docs.

test/e2e/scaffold/k8s.go Outdated Show resolved Hide resolved
@tao12345666333
Copy link
Member

You can just create one ApisixRoute resource, and enable the serverless plugin.
Then try to check the route and response.

@Chever-John Chever-John marked this pull request as ready for review April 15, 2022 03:13
@tao12345666333 tao12345666333 self-assigned this Apr 15, 2022
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

backends:
- serviceName: %s
servicePort: %d
weight: 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

backends:
- serviceName: %s
servicePort: %d
weight: 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

LGTM

Copy link
Member

@leslie-tsang leslie-tsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 merged commit f081121 into apache:master Apr 15, 2022
AlinsRan pushed a commit to AlinsRan/apisix-ingress-controller that referenced this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants