Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add 3 plugin test cases for e2e #965

Merged
merged 9 commits into from
Apr 18, 2022
Merged

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Apr 14, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Test cases include:

  • consumer-restriction plugin
  • csrf plugin
  • client-control plugin

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tao12345666333
Copy link
Member

Please run make e2e-names-check to check e2e test case name

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #965 (b19fa8f) into master (22cfb5e) will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #965      +/-   ##
==========================================
+ Coverage   31.75%   31.91%   +0.15%     
==========================================
  Files          72       73       +1     
  Lines        7935     7953      +18     
==========================================
+ Hits         2520     2538      +18     
  Misses       5139     5139              
  Partials      276      276              
Impacted Files Coverage Δ
pkg/kube/translation/annotations.go 61.53% <0.00%> (ø)
pkg/kube/translation/annotations/forward_auth.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ab065...b19fa8f. Read the comment docs.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just left a comment.

@tao12345666333 tao12345666333 self-assigned this Apr 14, 2022
@tao12345666333 tao12345666333 changed the title add consumer-restriction plugin test cases for e2e ci: add consumer-restriction plugin test cases for e2e Apr 14, 2022
@AlinsRan AlinsRan changed the title ci: add consumer-restriction plugin test cases for e2e ci: add 3 plugin test cases for e2e Apr 15, 2022
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
Only one point needs to be adjusted, other contents LGTM

test/e2e/suite-plugins/client-control.go Outdated Show resolved Hide resolved
test/e2e/suite-plugins/client-control.go Outdated Show resolved Hide resolved
test/e2e/suite-plugins/csrf.go Outdated Show resolved Hide resolved
test/e2e/suite-plugins/csrf.go Outdated Show resolved Hide resolved
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 merged commit 64e2768 into apache:master Apr 18, 2022
@lijing-21
Copy link

Hi @AlinsRan , thank you for your contribution!

Here is the Contributor T-shirt form[1], if you're interested, kindly take a look :)

[1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants