Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ApisixTls v2 #967

Merged
merged 12 commits into from
May 11, 2022
Merged

Conversation

lingsamuel
Copy link
Member

Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com

Type of change:

  • New feature provided

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2022

Codecov Report

Merging #967 (6993569) into master (aee6e78) will decrease coverage by 0.63%.
The diff coverage is 0.72%.

@@            Coverage Diff             @@
##           master     #967      +/-   ##
==========================================
- Coverage   31.75%   31.12%   -0.64%     
==========================================
  Files          72       73       +1     
  Lines        7935     8161     +226     
==========================================
+ Hits         2520     2540      +20     
- Misses       5139     5345     +206     
  Partials      276      276              
Impacted Files Coverage Δ
pkg/ingress/apisix_tls.go 0.00% <0.00%> (ø)
pkg/ingress/compare.go 0.00% <0.00%> (ø)
pkg/ingress/controller.go 0.91% <0.00%> (-0.03%) ⬇️
pkg/ingress/secret.go 0.00% <0.00%> (ø)
pkg/ingress/status.go 0.00% <0.00%> (ø)
pkg/kube/translation/apisix_ssl.go 0.00% <0.00%> (ø)
pkg/kube/translation/ingress.go 77.81% <0.00%> (ø)
pkg/kube/translation/translator.go 46.07% <ø> (ø)
cmd/ingress/ingress.go 78.64% <100.00%> (+0.20%) ⬆️
pkg/config/config.go 65.00% <100.00%> (+0.35%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee6e78...6993569. Read the comment docs.

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@lingsamuel lingsamuel marked this pull request as ready for review April 20, 2022 01:11
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Makefile Show resolved Hide resolved
pkg/ingress/compare.go Show resolved Hide resolved
pkg/ingress/controller.go Outdated Show resolved Hide resolved
pkg/ingress/controller.go Outdated Show resolved Hide resolved
pkg/kube/apisix_tls.go Outdated Show resolved Hide resolved
pkg/kube/apisix_tls.go Outdated Show resolved Hide resolved
pkg/kube/apisix_tls.go Outdated Show resolved Hide resolved
tools.go Outdated Show resolved Hide resolved
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one comment,
other content LGTM

pkg/ingress/controller.go Outdated Show resolved Hide resolved
Co-authored-by: Jintao Zhang <tao12345666333@163.com>
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/ingress/controller.go Outdated Show resolved Hide resolved
@lingsamuel lingsamuel merged commit e2f19b5 into apache:master May 11, 2022
@lingsamuel lingsamuel deleted the apisixtls-v2 branch May 11, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants