-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix some code formats #968
Conversation
Codecov Report
@@ Coverage Diff @@
## master #968 +/- ##
=======================================
Coverage 31.75% 31.75%
=======================================
Files 72 72
Lines 7935 7935
=======================================
Hits 2520 2520
Misses 5139 5139
Partials 276 276
Continue to review full report at Codecov.
|
Shouldn't code format be handled by lint or format tools? 🤔 |
Thank you for your contribution, I checked golang's documentation and haven't found any instructions about having to have a blank line after the license header file. Can you explain the need for this modification? |
Yes, Code format should be handled by the gofmt tool. |
In fact, the code in the current repo has passed the gofmt check |
@Gallardot Could you revert these parts? |
This reverts commit 68f2539.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It's just that some files have a newline after the license header and some don't. Just to keep the code in a consistent format.
Agree, maybe current tools don't cover this detail. Maybe we can make some adjustments back there. |
If we are modifying a feature in a file, I think it is acceptable to make adjustments to it in passing. |
Type of change:
What this PR does / why we need it:
ref:CodeReviewComment. Fix some code formats. IDE will not remind.
Pre-submission checklist: