Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: encapsulate functions to reuse code #971

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

nayihz
Copy link
Contributor

@nayihz nayihz commented Apr 16, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

ref: #969

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

Codecov Report

Merging #971 (326c95b) into master (f081121) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #971   +/-   ##
=======================================
  Coverage   31.91%   31.91%           
=======================================
  Files          73       73           
  Lines        7953     7953           
=======================================
  Hits         2538     2538           
  Misses       5139     5139           
  Partials      276      276           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f081121...326c95b. Read the comment docs.

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@tao12345666333 tao12345666333 merged commit 0f4391a into apache:master Apr 19, 2022
AlinsRan pushed a commit to AlinsRan/apisix-ingress-controller that referenced this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants