Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve the e2e test of referer-restriction plugin #976

Merged
merged 4 commits into from
May 10, 2022
Merged

feat: improve the e2e test of referer-restriction plugin #976

merged 4 commits into from
May 10, 2022

Conversation

Chever-John
Copy link
Contributor

@Chever-John Chever-John commented Apr 20, 2022

The original e2e testing of the referer-restriction plugin was not perfect, and the purpose of this PR is to improve the testing of the plugin.

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #976 (b433ce3) into master (0f4391a) will not change coverage.
The diff coverage is n/a.

❗ Current head b433ce3 differs from pull request most recent head f971dfa. Consider uploading reports for the commit f971dfa to get more accurate results

@@           Coverage Diff           @@
##           master     #976   +/-   ##
=======================================
  Coverage   31.91%   31.91%           
=======================================
  Files          73       73           
  Lines        7953     7953           
=======================================
  Hits         2538     2538           
  Misses       5139     5139           
  Partials      276      276           
Impacted Files Coverage Δ
pkg/api/router/apisix_healthz.go 66.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4391a...f971dfa. Read the comment docs.

@tao12345666333
Copy link
Member

thanks, can you add a case for check the message?

@Chever-John
Copy link
Contributor Author

thanks, can you add a case for check the message?

have finished it~

test/e2e/suite-plugins/referer-restriction.go Outdated Show resolved Hide resolved
test/e2e/suite-plugins/referer-restriction.go Outdated Show resolved Hide resolved
test/e2e/suite-plugins/referer-restriction.go Outdated Show resolved Hide resolved
test/e2e/suite-plugins/referer-restriction.go Outdated Show resolved Hide resolved
test/e2e/suite-plugins/referer-restriction.go Outdated Show resolved Hide resolved
test/e2e/suite-plugins/referer-restriction.go Outdated Show resolved Hide resolved
test/e2e/suite-plugins/referer-restriction.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jwrookie jwrookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@tao12345666333 tao12345666333 merged commit 1899d90 into apache:master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants