Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ApisixClusterConfig v2 #977

Merged
merged 5 commits into from
May 12, 2022

Conversation

lingsamuel
Copy link
Member

Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com

Type of change:

  • New feature provided

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@lingsamuel lingsamuel marked this pull request as draft April 21, 2022 01:30
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2022

Codecov Report

Merging #977 (33f04c5) into master (e2f19b5) will decrease coverage by 0.47%.
The diff coverage is 10.69%.

❗ Current head 33f04c5 differs from pull request most recent head 23b1e5c. Consider uploading reports for the commit 23b1e5c to get more accurate results

@@            Coverage Diff             @@
##           master     #977      +/-   ##
==========================================
- Coverage   31.03%   30.55%   -0.48%     
==========================================
  Files          74       74              
  Lines        8185     8320     +135     
==========================================
+ Hits         2540     2542       +2     
- Misses       5369     5502     +133     
  Partials      276      276              
Impacted Files Coverage Δ
pkg/ingress/apisix_cluster_config.go 0.00% <0.00%> (ø)
pkg/ingress/controller.go 0.89% <0.00%> (-0.03%) ⬇️
pkg/ingress/status.go 0.00% <0.00%> (ø)
pkg/kube/translation/translator.go 46.07% <ø> (ø)
pkg/kube/translation/global_rule.go 50.00% <91.66%> (-50.00%) ⬇️
cmd/ingress/ingress.go 78.84% <100.00%> (+0.20%) ⬆️
pkg/config/config.go 65.34% <100.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f19b5...23b1e5c. Read the comment docs.

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@lingsamuel lingsamuel marked this pull request as ready for review April 24, 2022 07:46
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

LGTM

pkg/ingress/apisix_cluster_config.go Outdated Show resolved Hide resolved
pkg/ingress/apisix_cluster_config.go Outdated Show resolved Hide resolved
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@tao12345666333 tao12345666333 added this to In progress in v1.5 Planning via automation May 11, 2022
@tao12345666333 tao12345666333 added changelog Issues with this label should be added to changelog when public a new release area/controller labels May 11, 2022
@tao12345666333 tao12345666333 self-assigned this May 11, 2022
@tao12345666333 tao12345666333 added this to the 1.5.0 milestone May 11, 2022
v1.5 Planning automation moved this from In progress to Reviewer approved May 11, 2022
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@lingsamuel
Copy link
Member Author

I resolved the conflicts, please review again @tao12345666333 @gxthrj

@lingsamuel lingsamuel merged commit bac9813 into apache:master May 12, 2022
v1.5 Planning automation moved this from Reviewer approved to Done May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller changelog Issues with this label should be added to changelog when public a new release
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants