Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add authorization-annotation the ingress resource #985

Merged
merged 47 commits into from
May 11, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Apr 27, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2022

Codecov Report

Merging #985 (3b24681) into master (4a0fc0c) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
- Coverage   31.91%   31.84%   -0.08%     
==========================================
  Files          73       74       +1     
  Lines        7953     7971      +18     
==========================================
  Hits         2538     2538              
- Misses       5139     5157      +18     
  Partials      276      276              
Impacted Files Coverage Δ
pkg/kube/translation/annotations.go 61.53% <ø> (ø)
pkg/kube/translation/annotations/authorization.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a0fc0c...3b24681. Read the comment docs.

@AlinsRan AlinsRan marked this pull request as ready for review April 27, 2022 08:20
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment.

LGTM

pkg/kube/translation/annotations/authorization.go Outdated Show resolved Hide resolved
Co-authored-by: Jintao Zhang <tao12345666333@163.com>
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 added changelog Issues with this label should be added to changelog when public a new release area/controller labels May 11, 2022
@tao12345666333 tao12345666333 self-assigned this May 11, 2022
@tao12345666333 tao12345666333 merged commit 670d671 into apache:master May 11, 2022
@AlinsRan AlinsRan deleted the auth_annotation branch June 9, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller changelog Issues with this label should be added to changelog when public a new release
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants