feat: PostResponse supports charset other than UTF-8
#239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyyir
changed the title
PostResponse supports charset other than UTF-8
nic-chen
reviewed
May 12, 2023
|
Added test cases. Thank you. |
nic-chen
reviewed
May 16, 2023
| @@ -53,7 +57,7 @@ public ByteBuffer encode() { | |||
|
|
|||
| int bodyIndex = -1; | |||
| if (StringUtils.hasText(body)) { | |||
| byte[] bodyBytes = body.getBytes(StandardCharsets.UTF_8); | |||
| byte[] bodyBytes = body.getBytes(charset); | |||
There was a problem hiding this comment.
Suggested change
| byte[] bodyBytes = body.getBytes(charset); | |
| byte[] bodyBytes = body.getBytes(this.charset); |
should be better?
There was a problem hiding this comment.
I've reflected your review. Thank you.
Gallardot
previously approved these changes
May 17, 2023
3 tasks
nic-chen
approved these changes
May 22, 2023
|
@joyyir thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Related issues
request help:
PostResponsesupports charset other thanUTF-8#238Bugfix
Description
How to fix?
New feature or improvement
Describe the details and related test reports.
PostResponseby default converts the body to bytes inUTF-8.It would be nice to support other charsets.
Source branch
main
Related commits and pull requests
Target branch
main