Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ExtraInfoResponse class getResult method bug #244

Merged
merged 8 commits into from Jun 2, 2023

Conversation

joyyir
Copy link
Contributor

@joyyir joyyir commented May 22, 2023

Please answer these questions before submitting a pull request


Bugfix


New feature or improvement

  • Describe the details and related test reports.

  • Source branch

  • Related commits and pull requests

  • Target branch

@nic-chen
Copy link
Member

This is a breaking change, even though the original bug existed.

We should add new methods to solve this issue, and then remove the problematic methods in a later version, what do you think?

@joyyir
Copy link
Contributor Author

joyyir commented May 22, 2023

This is a breaking change, even though the original bug existed.

We should add new methods to solve this issue, and then remove the problematic methods in a later version, what do you think?

I agree. I'll try to write another version, so please review it later.

@joyyir
Copy link
Contributor Author

joyyir commented May 22, 2023

Added a new method while maintaining the original method.

@nic-chen
Copy link
Member

hi @joyyir please fix the failed CI , thanks.

@joyyir
Copy link
Contributor Author

joyyir commented May 30, 2023

hi @joyyir please fix the failed CI , thanks.

Okay, I've added license header. Thanks.

@nic-chen nic-chen merged commit 8afa49e into apache:main Jun 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants