fix: convert the conf req to an object and put it in the cache #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ug of multiple buffer reads Signed-off-by: tzssangglass <tzssangglass@gmail.com>
|
relate to: #72 |
|
@huang-x-h @Rdebu pls verify this PR if fix your problem. |
spacewander
approved these changes
Sep 24, 2021
|
There is no problem for the time being, continue to observe for a few days
|
|
@seominho77 @dongqisilent verify this PR if fix your problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Related issues
fix: bug: Java pulugin ruuner filter get config occured java.lang.IndexOutOfBoundsException: null #63
Bugfix
Conf Req is currently put directly into the cache, but Conf Req is a DirectByteBuffer and multiple reads in different Http Call Reqs will cause exceptions
Convert the conf req to an object and put it in the cache to avoid errors caused by reading the buffer multiple times.
New feature or improvement
Describe the details and related test reports.
Source branch
Related commits and pull requests
Target branch