Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix error when forwarding tff files #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Chever-John
Copy link

fix issue #50

Just add a judgment statement.

@Chever-John
Copy link
Author

Chever-John commented Apr 26, 2022

@spacewander @shuaijinchao Plz give me a approval :)

@shuaijinchao
Copy link
Member

Add test cases?

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #51 (c5d0d5f) into master (3de14f8) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head c5d0d5f differs from pull request most recent head 1a0ccde. Consider uploading reports for the commit 1a0ccde to get more accurate results

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   91.72%   91.77%   +0.05%     
==========================================
  Files          11       11              
  Lines         749      754       +5     
==========================================
+ Hits          687      692       +5     
  Misses         62       62              
Impacted Files Coverage Δ
apisix/runner/utils/common.py 98.65% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de14f8...1a0ccde. Read the comment docs.

@Chever-John
Copy link
Author

Add test cases?

Yeah~
I will do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants