Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Site]: Clicking on the doc version dropdown will bring the doc page to the first available doc #1583

Closed
kayx23 opened this issue May 9, 2023 · 3 comments · Fixed by #1592
Closed

[Site]: Clicking on the doc version dropdown will bring the doc page to the first available doc #1583

kayx23 opened this issue May 9, 2023 · 3 comments · Fixed by #1592
Assignees
@ShantanuSutar

Comments

@kayx23
Copy link
Member

kayx23 commented May 9, 2023

Current State

Let's say we're on a plugin page. Now I want to switch doc version. The doc version dropdown shows up on hover, as expected. However if you accidentally (or out of habit) click on the dropdown, it brings the doc page to the first doc.

For a demo, please see below gif:

20230509135256_rec_

Desired State

The "click" on the doc version dropdown should not have a different behaviour than the hover.

Would you like to fix this issue?

None
@yzeng25
Copy link
Contributor

yzeng25 commented May 10, 2023

cc @SkyeYoung 👀

@ShantanuSutar
Copy link
Contributor

Can I work on this issue?@kayx23

@yzeng25
Copy link
Contributor

yzeng25 commented May 13, 2023

Can I work on this issue?@kayx23

Assigned.

@ShantanuSutar ShantanuSutar mentioned this issue May 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShantanuSutar ShantanuSutar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#issue 1583 doc version dropdown fixed ShantanuSutar/apisix-website
3 participants
@yzeng25 @kayx23 @ShantanuSutar