fix: deepcopy doesn't copy the metatable (#6623)

apache · Mar 16, 2022 · 91b57e6 · 91b57e6
1 parent ca2174a
commit 91b57e6
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/apisix/core/table.lua b/apisix/core/table.lua
@@ -128,6 +128,11 @@ do
             end
         end
 
+        local mt = getmetatable(orig)
+        if mt ~= nil then
+            setmetatable(copy, mt)
+        end
+
         return copy
     end
 

diff --git a/t/core/table.t b/t/core/table.t
@@ -204,3 +204,28 @@ ok
 GET /t
 --- no_error_log
 [error]
+
+
+
+=== TEST 7: deepcopy should keep metatable
+--- config
+    location /t {
+        content_by_lua_block {
+            local core = require("apisix.core")
+            local deepcopy = core.table.deepcopy
+            local t = setmetatable({}, core.json.array_mt)
+            local actual = core.json.encode(deepcopy(t))
+            local expect = "[]"
+            if actual ~= expect then
+                ngx.say("expect ", expect, ", actual ", actual)
+                return
+            end
+            ngx.say("ok")
+        }
+    }
+--- request
+GET /t
+--- response_body
+ok
+--- no_error_log
+[error]