Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: should not save the runtime data of plugin into etcd #1836

Closed
nic-chen opened this issue Jul 13, 2020 · 4 comments · Fixed by #1910
Closed

bug: should not save the runtime data of plugin into etcd #1836

nic-chen opened this issue Jul 13, 2020 · 4 comments · Fixed by #1910
Assignees
Labels
bug Something isn't working

Comments

@nic-chen
Copy link
Member

Issue description

admin api will pollute and save plugin_conf into etcd when calling plugin's function check_schema.
e.g. https://github.com/apache/incubator-apisix/blob/master/apisix/plugins/proxy-rewrite.lua#L111

Environment

  • apisix version (cmd: apisix version): 1.4
  • OS: centos7

Minimal test code / Steps to reproduce the issue

  1. add a route with plugin proxy_write
  2. view the route just added

What's the actual result? (including assertion message & call stack if applicable)

the runtime data of the plugin has be saved into etcd.

What's the expected result?

the runtime data of the plugin should't be saved into etcd.

@membphis
Copy link
Member

only Admin API has this bug.

@moonming moonming added the bug Something isn't working label Jul 14, 2020
@wrl96
Copy link
Contributor

wrl96 commented Jul 21, 2020

I think we should remove apisix.admin.plugins.check_schema, just check schema in sync_data

@membphis
Copy link
Member

@wrl96 Your way is dangerous, we don't allow dirty data to be stored in etcd.

@membphis membphis self-assigned this Jul 26, 2020
@membphis
Copy link
Member

I will fix this bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants