Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support empty nodes in Upstream #3072

Closed
tokers opened this issue Dec 18, 2020 · 0 comments
Closed

Support empty nodes in Upstream #3072

tokers opened this issue Dec 18, 2020 · 0 comments
Labels
discuss enhancement New feature or request

Comments

@tokers
Copy link
Contributor

tokers commented Dec 18, 2020

Improve Docs

Currently the minimum number of nodes in Upstream is 1, while using ingress-apisix in Kubernetes, people may create ApisixUpstream or ApisixRoute with an bad Service/Endpoints, which causes ingress-apisix push an Upstream but with an empty nodes field, and APISIX returns 400. So is there any restrictions that we must have at least one node?

Describe the solution you'd like

Allow empty node in Upstream.
@tokers tokers added the enhancement New feature or request label Dec 18, 2020
@nic-chen nic-chen mentioned this issue Dec 18, 2020
Closed
spacewander added a commit to spacewander/incubator-apisix that referenced this issue Dec 18, 2020
@spacewander
feat: allow upstream without nodes
5cff70a 
Fix apache#3072

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
spacewander added a commit to spacewander/incubator-apisix that referenced this issue Dec 18, 2020
@spacewander
feat: allow upstream without nodes
33b2542 
Fix apache#3072

Signed-off-by: spacewander <spacewanderlzx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juzhiyuan @tokers