Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove openldap dependencies from apisix #7865

Open
kingluo opened this issue Sep 6, 2022 · 2 comments · May be fixed by #10176
Open

feat: remove openldap dependencies from apisix #7865

kingluo opened this issue Sep 6, 2022 · 2 comments · May be fixed by #10176
Labels
good first issue Good for newcomers pending

Comments

@kingluo
Copy link
Contributor

kingluo commented Sep 6, 2022

Description

With lua-resty-ldap, apisix does not need openldap related dependencies anymore.

We could remove it in these files:

  • .github/workflows/fuzzing-ci.yaml:53: sudo apt-get install -y git openresty curl openresty-openssl111-dev unzip make gcc libldap2-dev
  • ci/centos7-ci.sh:26: git sudo openldap-devel which libxml2-devel openssl-devel libxslt-devel
  • ci/common.sh:130: apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev
  • ci/performance_test.sh:25: apt-get -y install lua5.1 liblua5.1-0-dev libldap2-dev
  • ci/pod/docker-compose.plugin.yml:148: openldap:
  • docs/en/latest/building-apisix.md:94: brew install openldap
  • t/chaos/utils/Dockerfile:34: openldap-dev
  • utils/install-dependencies.sh:49: local common_dep="curl wget git gcc openresty-openssl111-devel unzip pcre pcre-devel openldap-devel"
  • utils/install-dependencies.sh:87: sudo apt-get install -y git openresty curl openresty-openssl111-dev make gcc libpcre3 libpcre3-dev libldap2-dev unzip
  • utils/install-dependencies.sh:93: brew install openresty/brew/openresty luarocks lua@5.1 wget curl git pcre openldap
  • utils/linux-install-openresty.sh:51:sudo apt-get install "$openresty" openresty-openssl111-debug-dev libldap2-dev

We should also remove it in build-tools:
https://github.com/api7/apisix-build-tools/blob/acedbc07990929efd066b1c25b53e09c6d0d085f/package-apisix.sh#L10

@tzssangglass
Copy link
Member

LGTM

1 similar comment
@hanf2x
Copy link
Contributor

hanf2x commented Feb 20, 2023

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers pending
Projects
None yet
4 participants