Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support log with traceid when enable the zipkin plugin #10210

Closed
wants to merge 3 commits into from
Closed

feat: support log with traceid when enable the zipkin plugin #10210

wants to merge 3 commits into from

Conversation

wizhuo
Copy link
Contributor

@wizhuo wizhuo commented Sep 15, 2023

Description

As a user, I would like to automatically include the traceId when logging, especially when I have enabled the Zipkin plugin. This will make it easier for me to quickly identify the logs associated with a particular traceId when troubleshooting issues. Currently, manually concatenating the traceId with each log entry is cumbersome and not user-friendly. I hope that this issue can be addressed at the architectural level.

feat #10209

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@wizhuo wizhuo changed the title support log with traceid when enable the zipkin plugin feat:support log with traceid when enable the zipkin plugin Sep 15, 2023
@wizhuo wizhuo changed the title feat:support log with traceid when enable the zipkin plugin feat: support log with traceid when enable the zipkin plugin Sep 15, 2023
@monkeyDluffy6017
Copy link
Contributor

Thank you for your contribution, but not everyone will be using the zipkin plugin. Perhaps you can modify it this way in your own project.

@wizhuo
Copy link
Contributor Author

wizhuo commented Sep 19, 2023

Thank you for your contribution, but not everyone will be using the zipkin plugin. Perhaps you can modify it this way in your own project.

Yes, indeed, not everyone will enable Zipkin, so the current changes should not affect users who don't use Zipkin. We've simply made user-friendly adjustments for those using Zipkin . after all, when Zipkin is in use, users expect traceId to be automatically recorded in the logs. This makes troubleshooting more convenient for everyone. I believe this capability would also be well-received by other users. What do you think?

@monkeyDluffy6017
Copy link
Contributor

There are some other similar plugins like request-id, and there will be more in the future, we should not assume that users will use a specific plugin.

@wizhuo
Copy link
Contributor Author

wizhuo commented Sep 19, 2023

There are some other similar plugins like request-id, and there will be more in the future, we should not assume that users will use a specific plugin.

Sounds reasonable, then I'll close it.

@wizhuo wizhuo closed this Sep 19, 2023
@Gallardot
Copy link
Member

Gallardot commented Sep 28, 2023

Hi @wizhuo , I understand the purpose of your PR and I also use zipkin plugin. Perhaps you can refer to this opentelemetry plugin PR for an implementation of the zipkin plugin. Would you like to help the community to explore this? Thank you for your contribution.

@wizhuo
Copy link
Contributor Author

wizhuo commented Oct 2, 2023

Hi @wizhuo , I understand the purpose of your PR and I also use zipkin plugin. Perhaps you can refer to this opentelemetry plugin PR for an implementation of the zipkin plugin. Would you like to help the community to explore this? Thank you for your contribution.

Yes,I would like to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants