Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support configuring the buffer size of the access log #10225

Merged
merged 1 commit into from Sep 19, 2023

Conversation

qihaiyan
Copy link
Contributor

@qihaiyan qihaiyan commented Sep 18, 2023

Description

access log's buffer size can be configed.

Access log buffering can significantly reduce disk I/O and improve server performance. Enabling access log buffering is relatively simple in NGINX. To do this, use the following directive in your NGINX configuration:

access_log /var/log/nginx/access.log main buffer=32k;
This directive tells NGINX to store the access log entries in a buffer of size 32k before writing them to the log file. Increasing the buffer size can minimize the number of write operations to the disk, resulting in improved performance.

Fixes #10219

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@qihaiyan qihaiyan changed the title access log's buffer size can be configed feat: access log's buffer size can be configed Sep 18, 2023
@shreemaan-abhishek
Copy link
Contributor

Please also describe why this is needed.

@qihaiyan
Copy link
Contributor Author

Please also describe why this is needed.

I enriched the description.

@monkeyDluffy6017 monkeyDluffy6017 changed the title feat: access log's buffer size can be configed feat: support configuring the buffer size of the access log Sep 19, 2023
@monkeyDluffy6017 monkeyDluffy6017 merged commit 57a7dcd into apache:master Sep 19, 2023
33 of 34 checks passed
@qihaiyan qihaiyan deleted the fix-10219 branch September 20, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: As a user, I want to access log's buffer size can be configed in config file
3 participants