Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: remove self-contained info fields from ssl definition #10323

Merged
merged 1 commit into from Oct 13, 2023
Merged

change: remove self-contained info fields from ssl definition #10323

merged 1 commit into from Oct 13, 2023

Conversation

Sn0rt
Copy link
Contributor

@Sn0rt Sn0rt commented Oct 12, 2023

Description

Fixes #10094

email: https://lists.apache.org/thread/8l4h8f6wcv482s0b7vt17do5z3g1y3o3

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>
@jiangfucheng
Copy link
Member

@Sn0rt Hi, I replied to your email yesterday, but I am not sure if you received it, so, I am pasting the email content now.

I basically agree with you idea. Now APISIX not use "validity_start" and "validity_start" fields no matter we set or read "ssl" resource. But APISIX Dashboard will set these fields when we add SSL resources, and it will display these fields on the web page, a user has raised an issue regarding this before. #10063
Maybe we should be compatible with this logic in APISIX Dashboard first, and remove these fields in APISIX.
What do you think?

@Sn0rt
Copy link
Contributor Author

Sn0rt commented Oct 13, 2023

@jiangfucheng

I have not recive your reponse email yet. you can click the email list for confirm.

apache/apisix is the core project. to remove this field from apisix, we can merge it into it first.

  1. APISIX-dashboard is a side project of APISIX and needs to be compatible with apisix instead of APISIX compatible with APISIX-dashboard. (I will create an issue under apisix-dashboard to track this requirement after this PR has been merged.)

  2. The apisix-dashbaord compatibility guarantee is only up to 3.0.x. Currently, apisix has been released to 3.6.x.

@jiangfucheng
Copy link
Member

@jiangfucheng

I have not recive your reponse email yet. you can click the email list for confirm.

apache/apisix is the core project. to remove this field from apisix, we can merge it into it first.

  1. APISIX-dashboard is a side project of APISIX and needs to be compatible with apisix instead of APISIX compatible with APISIX-dashboard. (I will create an issue under apisix-dashboard to track this requirement after this PR has been merged.)
  2. The apisix-dashbaord compatibility guarantee is only up to 3.0.x. Currently, apisix has been released to 3.6.x.

Got it, I think it's reasonable.

@monkeyDluffy6017 monkeyDluffy6017 merged commit 167f886 into apache:master Oct 13, 2023
31 checks passed
@Sn0rt Sn0rt deleted the apisix/schema_def.lua branch October 24, 2023 09:01
isman-usoh added a commit to isman-usoh/apisix-dashboard that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove create_time and update_time for resources in admin api
3 participants