Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin/opa): safely remove upstream when sending route to opa #10552

Merged
merged 6 commits into from
Nov 30, 2023
Merged

fix(plugin/opa): safely remove upstream when sending route to opa #10552

merged 6 commits into from
Nov 30, 2023

Conversation

shreemaan-abhishek
Copy link
Contributor

Description

Fixes #10483

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@shreemaan-abhishek
Copy link
Contributor Author

@WrightKD please review this PR.

WrightKD
WrightKD approved these changes Nov 28, 2023
View reviewed changes
Copy link

@WrightKD WrightKD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bzp2010
bzp2010 reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@bzp2010 bzp2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ci/pod/opa/allow_get.rego Outdated Show resolved Hide resolved
@moonming moonming merged commit fc5bf2b into apache:master Nov 30, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sn0rt Sn0rt Sn0rt approved these changes

@bzp2010 bzp2010 bzp2010 approved these changes

@moonming moonming moonming approved these changes

@WrightKD WrightKD WrightKD approved these changes

@luoluoyuyu luoluoyuyu luoluoyuyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: OPA Plugin with the attribute "with_route" set to true causes a 500 status error
6 participants
@shreemaan-abhishek @Sn0rt @bzp2010 @moonming @WrightKD @luoluoyuyu