fix: missing etcd init_dir and unable to list resource #10569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luoluoyuyu
approved these changes
Nov 30, 2023
monkeyDluffy6017
approved these changes
Nov 30, 2023
bzp2010
approved these changes
Nov 30, 2023
| nodes = setmetatable({}, array_mt) | ||
| } | ||
| local kvs = res.body.kvs | ||
| if #kvs >= 1 and not kvs[1].value then |
There was a problem hiding this comment.
not kvs[1].value
With all due respect, this is a completely false assumption. Why is the value null?
The lua-resty-etcd uses cjson.safe to parse JSON, so init_dir values that are not in JSON format will be parsed as nil.
Therefore, I think this is only a temporary solution that cannot solve the problem completely.
There was a problem hiding this comment.
This is the previous logic, I did not modify it.
The previous non empty processing method was incorrect, I just improved it.
There was a problem hiding this comment.
However, I think you are right. To improve this, I think we can add a judgment, such as or value="init_dir"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9618
Checklist